Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Joss edits #212

Merged
merged 142 commits into from
Jun 14, 2024
Merged

Joss edits #212

merged 142 commits into from
Jun 14, 2024

Conversation

mdtanker
Copy link
Owner

@mdtanker mdtanker commented Jun 14, 2024 •
edited
Loading

This is the main PR from edits resulting from submission to the Journal of Open Source Software (JOSS). The journal review is located at openjournals/joss-reviews#6502. This PR was originally #195, but was migrated here after some merge conflicts. This StackOverflow answer was helpful in fixing the merge conflicts:

mdtanker and others added 30 commits June 14, 2024 08:56
@mdtanker
chore: increase timeout for test shen moho
0aad575
@mdtanker
build: explicitly specify tqdm as dependency
de4298b
@mdtanker
docs: update contributing guide
fd81ff9
@mdtanker
chore: cleanup Make commands
65095bf
@mdtanker
docs: simplify binder env
fa33bde
@mdtanker
refactor: update np random number generator
ccb9b41
@mdtanker
chore: update ruff version in pre-commit
53170ed
@mdtanker
style: reformat with new ruff version
54fd4cd
@mdtanker
docs: remove python version and nodefaults from binder env
73f7472
@mdtanker
docs: fix issues with subplot_layout example
1b2a3d8
@mdtanker
docs: try nbgitpull link for launch binder buttons
85d57ba
@mdtanker
docs: switch binder env to separate repo, remove launch buttons
05dbdf2
@mdtanker
docs: conform fetch walkthrough to standard figure creation style
5724805
@mdtanker
chore: add tests for regions
0881b9d
@mdtanker
style: fix regions test styling
b383fbb
@mdtanker
style: add typing to function
1113209
@mdtanker
docs: add available dataset gallery
e6978d9
@mdtanker
docs: update dataset gallery template
4d6f666
@mdtanker
docs: update bedmap2 dataset notebook
496866d
@mdtanker
docs: add bedmachine dataset notebook
36ae2be
@mdtanker
fix: remove faulty layer name from fetch bedmachine
9ab89cc
@mdtanker
docs: mention dataset gallery in fetch walkthrough
44dcff4
@mdtanker
docs: update references
76490ab
@mdtanker
docs: add more dataset notebooks
86767ac
@mdtanker
docs: reorganize available dataset gallery
88c00ba
@mdtanker
chore: don't run tests on docs or style commits
ca6d0e7
@mdtanker
feat: add Arctic/Greenland to utils/maps
02f750a
@mdtanker
feat: add some Greenland regions
6b9bd9d
@mdtanker
feat: add fetch MODIS Greenland
088b3f7
@mdtanker
feat: add pen kwarg to show_region
6de294d
This was referenced Jun 14, 2024
Closed
Closed
This was linked to issues Jun 14, 2024
Clarify use and data types in docs #202
Closed
Issues related to the description of region and box parameters #180
Closed
@mdtanker mdtanker mentioned this pull request Jun 14, 2024
Closed
This was linked to issues Jun 14, 2024
Problems with the use of "plot_grd" function of the module "maps" #207
Closed
Use environment variables to define which hemisphere to default to #208
Closed
mdtanker added 3 commits June 14, 2024 09:23
@mdtanker
chore: add fetch mark to some tests
ed94337
@mdtanker
chore: don't run fetch calls during test
8581461 
This should drastically speed up testing, not overload GHA with downloading datasets, but means testing of fetch calls will need to be performed manual by deleting the local pooch cache and rerun all fetch calls / tests.
@mdtanker
docs: spelling mistake
f827c8a
@github-actions GitHub Actions
Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.4.0-rc.1.

@codecov Codecov
Copy link

codecov bot commented Jun 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 5.10381% with 1097 lines in your changes missing coverage. Please review.

Project coverage is 9.93%. Comparing base (9a8ae51) to head (d4cf6b0).
Report is 257 commits behind head on main.

Files with missing lines Patch % Lines
src/polartoolkit/profiles.py 0.00% 539 Missing ⚠️
src/polartoolkit/maps.py 0.34% 286 Missing ⚠️
src/polartoolkit/fetch.py 4.73% 181 Missing ⚠️
src/polartoolkit/utils.py 29.68% 90 Missing ⚠️
src/polartoolkit/profile.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #212       +/-   ##
==========================================
- Coverage   35.43%   9.93%   -25.51%     
==========================================
  Files           6       7        +1     
  Lines        2627    3121      +494     
==========================================
- Hits          931     310      -621     
- Misses       1696    2811     +1115

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.4.0-rc.1.

1 similar comment
@github-actions GitHub Actions
Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.4.0-rc.1.

@github-actions GitHub Actions
Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.4.0-rc.1.

@github-actions GitHub Actions
Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.4.0-rc.1.

@github-actions GitHub Actions
Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.4.0-rc.1.

@mdtanker
refactor: change module name from profile to profiles to match pl…
03e248f 
…ural style of other modules.

BREAKING CHANGE: please update all import statements to use `profiles` instead of `profile`!
@github-actions GitHub Actions
Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.4.0-rc.1.

@github-actions GitHub Actions
Copy link

🔔 Thank you for raising your pull request.
📦 If merged, this PR will release version 0.4.0-rc.1.

@mdtanker mdtanker merged commit c0ffc0c into main Jun 14, 2024
16 of 18 checks passed
@mdtanker mdtanker deleted the joss-edits branch June 14, 2024 10:58
This was referenced Jun 14, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mdtanker