Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros/CSSRef): update zh-CN translation of CSSRef #9791

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

jasonren0403
Copy link
Contributor

Summary

the same as title

part of mdn/translated-content#13881

cc: @yin1999 @awxiaoxian2020

Problem

some zh-CN sidebar strings is missing in CSSRef

Solution

add the missing keys and update existing ones to improve consistency

@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Oct 11, 2023
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost looks good to me, just some suggestions 👍

kumascript/macros/CSSRef.ejs Outdated Show resolved Hide resolved
kumascript/macros/CSSRef.ejs Outdated Show resolved Hide resolved
kumascript/macros/CSSRef.ejs Outdated Show resolved Hide resolved
@jasonren0403 jasonren0403 requested a review from yin1999 October 11, 2023 13:56
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jasonren0403 👍

@yin1999
Copy link
Member

yin1999 commented Oct 17, 2023

/ping @caugner

@caugner caugner enabled auto-merge (squash) October 18, 2023 12:20
@caugner caugner merged commit 48ad86d into mdn:main Oct 18, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros needs review from l10n teams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants