-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(css): update order demo #2660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me; much improved, thanks @OnkarRuikar! Just one small suggestion to consider.
flex: 1; | ||
} | ||
|
||
#example-element { | ||
background-color: rgba(255, 0, 200, 0.2); | ||
border: 3px solid rebeccapurple; | ||
} | ||
|
||
#example-element::after { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, so for the variable order
box, you are printing the order value set on it at any time. Seems like a nice addition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSS is awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution. |
@OnkarRuikar OK, so this one is merged, but I don't know how quickly these changes will appear on MDN. Feel free to ping me when the change appears, and the time is right for merging mdn/content#30213 |
Then merge content PR that will go live tonight. |
The PR
order: 0;
option to start demo with initial position to avoid confusion