Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): update order demo #2660

Merged
merged 3 commits into from
Nov 13, 2023
Merged

fix(css): update order demo #2660

merged 3 commits into from
Nov 13, 2023

Conversation

OnkarRuikar
Copy link
Contributor

The PR

  • changes flex flow to column
  • mentions styles in boxes' contents
  • provides order: 0; option to start demo with initial position to avoid confusion

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner November 12, 2023 11:42
@OnkarRuikar OnkarRuikar requested review from chrisdavidmills and removed request for a team November 12, 2023 11:42
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me; much improved, thanks @OnkarRuikar! Just one small suggestion to consider.

live-examples/css-examples/flexbox/order.html Outdated Show resolved Hide resolved
flex: 1;
}

#example-element {
background-color: rgba(255, 0, 200, 0.2);
border: 3px solid rebeccapurple;
}

#example-element::after {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so for the variable order box, you are printing the order value set on it at any time. Seems like a nice addition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS is awesome!

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@chrisdavidmills chrisdavidmills merged commit be57d9c into mdn:main Nov 13, 2023
5 checks passed
Copy link

Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution.

@chrisdavidmills
Copy link
Contributor

@OnkarRuikar OK, so this one is merged, but I don't know how quickly these changes will appear on MDN. Feel free to ping me when the change appears, and the time is right for merging mdn/content#30213

@OnkarRuikar OnkarRuikar deleted the css_order branch November 13, 2023 09:32
@OnkarRuikar
Copy link
Contributor Author

Then merge content PR that will go live tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants