Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): on 'order' page explain 'Try it' section #30213

Merged
merged 3 commits into from
Nov 15, 2023
Merged

fix(css): on 'order' page explain 'Try it' section #30213

merged 3 commits into from
Nov 15, 2023

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar commented Nov 12, 2023 •
edited
Loading

⚠️ Note: merge mdn/interactive-examples#2660 first

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner November 12, 2023 11:27
@OnkarRuikar OnkarRuikar requested review from chrisdavidmills and removed request for a team November 12, 2023 11:27
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Nov 12, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2023 •
edited
Loading

Preview URLs

(comment last updated: 2023-11-13 09:15:07)

@OnkarRuikar OnkarRuikar mentioned this pull request Nov 12, 2023
Merged
@OnkarRuikar OnkarRuikar changed the title fix(css): explain 'Try it' section fix(css): on 'order' page explain 'Try it' section Nov 12, 2023
chrisdavidmills
chrisdavidmills requested changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of suggestions for you here, @OnkarRuikar.

files/en-us/web/css/order/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/order/index.md Outdated Show resolved Hide resolved
chrisdavidmills
chrisdavidmills approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, LGTM.

@estelle estelle merged commit a0371ae into mdn:main Nov 15, 2023
7 checks passed
@OnkarRuikar OnkarRuikar deleted the css_order branch November 15, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing demo
3 participants
@OnkarRuikar @chrisdavidmills @estelle