Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

string-indexof.js - comments don't match output #2653

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

hamishwillee
Copy link
Contributor

Fixes #2654

The example is used in https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/indexOf so you can easily see that the values don't match the expected output.

@hamishwillee hamishwillee requested a review from a team as a code owner November 5, 2023 21:41
@hamishwillee hamishwillee requested review from teoli2003 and removed request for a team November 5, 2023 21:41
@bsmth bsmth mentioned this pull request Nov 6, 2023
@bsmth bsmth self-requested a review November 6, 2023 08:50
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bsmth bsmth merged commit 9a20661 into main Nov 6, 2023
6 checks passed
@bsmth bsmth deleted the hamishwillee-patch-1 branch November 6, 2023 08:51
Copy link

github-actions bot commented Nov 6, 2023

Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expected output is wrong
2 participants