Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: expected output comments for indexOf example #2652

Closed
wants to merge 1 commit into from
Closed

Conversation

tvxxd
Copy link

@tvxxd tvxxd commented Nov 5, 2023

Description

The comments stated that the first occurrence of the search term "dog" should be at index 7, and the second occurrence at index 41. However, the correct values should be 15 for the first occurrence and 38 for the second occurrence.

Related issues and pull requests

incorrect expected output comments in the indexOf example Fixes mdn/interactive-examples#2654

@tvxxd tvxxd requested a review from a team as a code owner November 5, 2023 19:38
@tvxxd tvxxd requested review from Josh-Cena and removed request for a team November 5, 2023 19:38
Copy link

github-actions bot commented Nov 5, 2023

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

@bsmth
Copy link
Member

bsmth commented Nov 6, 2023

Thanks a lot for the proposed fix @tvxxd - I've just merged in a similar PR which addresses this in #2653 so I will close for now :)

@bsmth bsmth closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants