Make display modes more curated #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davewongillies
commented
Sep 11, 2024
davewongillies
force-pushed
the
display_modes
branch
from
d77ba72 to
b17d2a3
Compare
|
just left a couple superficial formatting notes |
I think you forgot to submit the formatting notes 🙂 |
mattpannella
requested changes
Sep 11, 2024
davewongillies
force-pushed
the
display_modes
branch
from
d0513be to
7d44815
Compare
davewongillies
force-pushed
the
display_modes
branch
from
7d44815 to
7075cab
Compare
davewongillies
force-pushed
the
display_modes
branch
from
7075cab to
a5dc26a
Compare
mattpannella
approved these changes
Sep 11, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this approach is something you're interested in @mattpannella but I've compiled it locally and it works well enough at the expense of having every single display mode configured on all cores.
Basically if there are display modes that are specific to a device, that core will get those display modes plus the generic ones, otherwise they get the generic ones.
This should close issue #328