Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analog display mode limit? #328

Closed
andrewkendall opened this issue Sep 10, 2024 · 4 comments
Closed

Analog display mode limit? #328

andrewkendall opened this issue Sep 10, 2024 · 4 comments

Comments

@andrewkendall
Copy link

andrewkendall commented Sep 10, 2024

I’m sure people have noticed this already, but just in case: I think the Analog firmware 2.3 has a limit on how many display modes can be used on a core. I was really excited for the Lynx screen filters, so I enabled all of them as soon as I updated the firmware. By default, I can’t use all the screen modes. It stops working at the Original Lynx mode.

However, if I manually edit the config file and remove some modes, I can use the Lynx ones without any problems. I don’t think this is a major issue — I’d be fine losing the Game Boy screen modes from most cores.

Steps to replicate: enable all display modes, then try the Lynx core, cycling through all modes with the D-pad combo.

@mattpannella
Copy link
Owner

yeah everyone kinda stumbled into this at the same time
i think the real fix is letting you choose which modes to enable

@andrewkendall
Copy link
Author

andrewkendall commented Sep 10, 2024

Yeah, I figured it was pretty hard to miss. This is likely just a personal thing, but I always thought enabling all modes for all cores felt a bit messy. The specific handheld filters feel like they have very little utility in a lot of scenarios. Now that there’s a firmware limit that’s been hit, I wonder, would it be better to be a little more opinionated by default?

Enable the generic subset for all cores:

•	“0x10”, // CRT Trinitron
•	“0x20”, // Grayscale LCD
•	“0x30”, // Reflective Color LCD
•	“0x40”, // Backlit Color LCD
•	“0xE0”, // Pinball Neon Matrix
•	“0xE1”, // Vacuum Fluorescent

Then match per core with the most appropriate ones, so PC Engine gets those plus:

•	“0x71”, // TurboExpress
•	“0x72”, // PC Engine LT

Lynx gets generic plus Lynx, etc.:

•	“0x81”, // Original Lynx
•	“0x82”, // Original Lynx+

I feel like sensible defaults would work for most people, with an option to choose more on a per-core basis if you really want them.

Anyway, just an idea, feel free to ignore. Amazing work on this program, by the way. I’ve been using it from the start, and the screen mode “enable all” is the only thing I’ve ever thought could be improved, and that was before this limit, so it felt like a good time to mention.

@kurohouou
Copy link

Would be nice if by default it would only show the ones specific to the core, like GB should have GB modes, GBA only shows GBA modes.. I really don't need a Trinitron mode for my Gameboy... But now that were at a limit at the very least it should make sure each core at least has its specific modes first.

@mattpannella
Copy link
Owner

i havent reviewed yet, but #331 should cover this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants