Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test stability] Improve stability of Tracker\RequestSetTest #22200

Merged
merged 1 commit into from
May 10, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 8, 2024

Description:

The test currently sometimes randomly fails. The reason for this is, that a request contains a timestamp, which might get higher between the calls of buildRequest

Review

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels May 8, 2024
@sgiehl sgiehl added this to the 5.1.0 milestone May 8, 2024
@sgiehl sgiehl requested a review from a team May 8, 2024 13:27
@sgiehl sgiehl merged commit cc85b43 into 5.x-dev May 10, 2024
21 of 25 checks passed
@sgiehl sgiehl deleted the requestsettest branch May 10, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants