Improve stability of Tracker\RequestSetTest (#22200)

matomo-org · May 10, 2024 · cc85b43 · cc85b43
1 parent c48b2ab
commit cc85b43
Showing 1 changed file with 11 additions and 7 deletions.
diff --git a/tests/PHPUnit/Unit/Tracker/RequestSetTest.php b/tests/PHPUnit/Unit/Tracker/RequestSetTest.php
@@ -116,18 +116,22 @@ public function testSetRequestsShouldConvertNonRequestInstancesToARequestInstanc
 
     public function testSetRequestsShouldIgnoreEmptyRequestsButNotArrays()
     {
-        $requests = array(
-            $this->buildRequest(5),
+        $request1 = $this->buildRequest(5);
+        $request2 = $this->buildRequest(2);
+        $request3 = $this->buildRequest(6);
+
+        $requests = [
+            $request1,
             null,
-            $this->buildRequest(2),
+            $request2,
             0,
-            $this->buildRequest(6),
-            array()
-        );
+            $request3,
+            []
+        ];
 
         $this->requestSet->setRequests($requests);
 
-        $expected = array($this->buildRequest(5), $this->buildRequest(2), $this->buildRequest(6), new Request(array()));
+        $expected = [$request1, $request2, $request3, new Request([])];
         $this->assertEquals($expected, $this->requestSet->getRequests());
     }