Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve API error UI test by checking for content instead of screenshot #21615

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Improve API error UI test by checking for content instead of screenshot #21615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions tests/UI/expected-screenshots/UIIntegrationTest_api_error.png
View file
Open in desktop

This file was deleted.

6 changes: 4 additions & 2 deletions tests/UI/specs/UIIntegration_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -910,8 +910,10 @@ describe("UIIntegrationTest", function () { // TODO: Rename to Piwik?
await page.goto(adminUrl);
await page.waitForSelector('#notificationContainer');

const pageWrap = await page.$('.pageWrap, #notificationContainer');
expect(await pageWrap.screenshot()).to.matchImage('api_error');
const notificationContent = await page.evaluate(() => $('#notificationContainer').text().trim());

// ensure no notification is being displayed
expect(notificationContent).to.be.empty;
});
});

Expand Down
Loading