Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve API error UI test by checking for content instead of screenshot #21615

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 30, 2023

Description:

The test is meant to check that no notification is shown in administration in case of an API error.
Taking a screenshot is quite useless there, as it only shows the admin overview. A notification might appear in case of a regression. Simply checking for the text content should therefor be a better choice.

Note: This test also regressed in #21605 due to the menu changes 🙈

Review

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Nov 30, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Nov 30, 2023
@sgiehl sgiehl requested a review from a team November 30, 2023 14:08
@mneudert mneudert merged commit b263384 into 5.x-dev Nov 30, 2023
23 of 25 checks passed
@mneudert mneudert deleted the improveuitest branch November 30, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants