templater: add commit.diff().<format>() methods
#4099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm going to add diff() method which provides no guarantee about content encoding.
…uments This will help remove lifetimed &dyn Repo from diff object in templater. Function arguments are reordered in a way that all show_*() functions have common parameters in the same order.
This patch adds TreeDiff template type to host formatting options. The main reason of this API design is that diff formats have various incompatible parameters, so a single .diff(files, format[, options..]) method would become messy pretty quickly. Another reason is that we can probably add custom summary templating support as diff.files().map(|file| file.path()..). RepoPathUiConverter is passed to templater explicitly because the one stored in RevsetParseContext is behind Option<_>.
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md