Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow restricting log diff/patch output to revset #4094

Closed
wants to merge 1 commit into from

Conversation

algmyr
Copy link
Collaborator

@algmyr algmyr commented Jul 15, 2024

Putting this up for now to gather feedback on the feature.

1000006396

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@algmyr algmyr force-pushed the algmyr/push-yyszmskxolpk branch from 45a61e4 to 7135b2a Compare July 15, 2024 22:03
@algmyr algmyr force-pushed the algmyr/push-yyszmskxolpk branch from 7135b2a to d1cfe93 Compare July 16, 2024 00:48
@yuja
Copy link
Collaborator

yuja commented Jul 16, 2024

If this is supposed to be used statically (user-configured default or named template), maybe we can include the diff summary in template?

builtin_log_compact ++ if(self.contained_in("ancestors(@, 2)"), self.diff().summary())

(I'm going to add commit.diff() template method.)

@algmyr
Copy link
Collaborator Author

algmyr commented Jul 16, 2024

That would be a probably better alternative to this, yeah

@algmyr
Copy link
Collaborator Author

algmyr commented Sep 3, 2024

Closing this as #4099 should have added the template machinery needed to replicate this

@algmyr algmyr closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants