Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add DAI-based inflation attack test (SC-480) #10

Merged
merged 11 commits into from
Jun 20, 2024
Merged

test: Add DAI-based inflation attack test (SC-480) #10

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d5d2d1e
test: move to use setup
lucas-manuel Jun 18, 2024
671d90f
test: refactor to add dai tests
lucas-manuel Jun 18, 2024
4785e2f
fix: rm todo
lucas-manuel Jun 18, 2024
c2bd832
fix: rm assertions
lucas-manuel Jun 18, 2024
f9ffcf2
fix: rm redundant psm deployment
lucas-manuel Jun 18, 2024
04656ff
fix: rm dos attack test
lucas-manuel Jun 18, 2024
3f8a432
fix: add back
lucas-manuel Jun 18, 2024
a85ca1c
Merge branch 'master' into sc-480-dai-inflation-attack-test
lucas-manuel Jun 20, 2024
c8efbb3
fix: merge conflicts
lucas-manuel Jun 20, 2024
b1a3498
fix: update unused import
lucas-manuel Jun 20, 2024
fbaa46a
fix: merge conflicts
lucas-manuel Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 39 additions & 22 deletions test/InflationAttack.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,55 @@ pragma solidity ^0.8.13;

import "forge-std/Test.sol";

import { PSM3 } from "src/PSM3.sol";

import { PSMTestBase } from "test/PSMTestBase.sol";

contract InflationAttackTests is PSMTestBase {
hexonaut marked this conversation as resolved.
Show resolved Hide resolved

// TODO: Decide if DAI test is needed
address firstDepositor = makeAddr("firstDepositor");
address frontRunner = makeAddr("frontRunner");
address deployer = makeAddr("deployer");

function test_inflationAttack_noInitialDeposit_sDai() public {
// Step 1: Front runner deposits 1 sDAI to get 1 share

function test_inflationAttack_noInitialDeposit() public {
psm = new PSM3(address(dai), address(usdc), address(sDai), address(rateProvider));
// Have to use sDai because 1 USDC mints 1e12 shares
_deposit(address(sDai), frontRunner, 1);

address firstDepositor = makeAddr("firstDepositor");
address frontRunner = makeAddr("frontRunner");
_runInflationAttack_noInitialDepositTest();
}

function test_inflationAttack_noInitialDeposit_dai() public {
// Step 1: Front runner deposits 1 sDAI to get 1 share

// Have to use sDai because 1 USDC mints 1e12 shares
// Have to use DAI because 1 USDC mints 1e12 shares
_deposit(address(dai), frontRunner, 1);

_runInflationAttack_noInitialDepositTest();
}

function test_inflationAttack_useInitialDeposit_sDai() public {
_deposit(address(sDai), address(deployer), 0.8e18); // 1e18 shares

// Step 1: Front runner deposits sDAI to get 1 share

// User tries to do the same attack, depositing one sDAI for 1 share
_deposit(address(sDai), frontRunner, 1);

_runInflationAttack_useInitialDepositTest();
}

function test_inflationAttack_useInitialDeposit_dai() public {
_deposit(address(dai), address(deployer), 1e18); // 1e18 shares

// Step 1: Front runner deposits dai to get 1 share

// User tries to do the same attack, depositing one sDAI for 1 share
_deposit(address(dai), frontRunner, 1);

_runInflationAttack_useInitialDepositTest();
}

function _runInflationAttack_noInitialDepositTest() internal {
assertEq(psm.shares(frontRunner), 1);

// Step 2: Front runner transfers 10m USDC to inflate the exchange rate to 1:(10m + 1)
Expand Down Expand Up @@ -58,20 +88,7 @@ contract InflationAttackTests is PSMTestBase {
assertEq(usdc.balanceOf(frontRunner), 15_000_000e6);
}

function test_inflationAttack_useInitialDeposit() public {
psm = new PSM3(address(dai), address(usdc), address(sDai), address(rateProvider));

address firstDepositor = makeAddr("firstDepositor");
address frontRunner = makeAddr("frontRunner");
address deployer = address(this); // TODO: Update to use non-deployer receiver

_deposit(address(sDai), address(this), 0.8e18); /// 1e18 shares

// Step 1: Front runner deposits sDAI to get 1 share

// User tries to do the same attack, depositing one sDAI for 1 share
_deposit(address(sDai), frontRunner, 1);

function _runInflationAttack_useInitialDepositTest() internal {
assertEq(psm.shares(frontRunner), 1);

// Step 2: Front runner transfers 10m USDC to inflate the exchange rate to 1:(10m + 1)
Expand Down
Loading