Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add DAI-based inflation attack test (SC-480) #10

Merged
merged 11 commits into from
Jun 20, 2024
Merged

test: Add DAI-based inflation attack test (SC-480) #10

merged 11 commits into from
Jun 20, 2024

Conversation

lucas-manuel
Copy link
Contributor

@lucas-manuel lucas-manuel commented Jun 18, 2024 •
edited
Loading

Add test for DAI to be used by attacker as well.

@lucas-manuel lucas-manuel self-assigned this Jun 18, 2024
hexonaut
hexonaut requested changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@hexonaut hexonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import, but rest looks good.

test/InflationAttack.t.sol Show resolved Hide resolved
@lucas-manuel lucas-manuel requested a review from hexonaut June 20, 2024 13:25
@lucas-manuel lucas-manuel merged commit dc40383 into master Jun 20, 2024
2 checks passed
@lucas-manuel lucas-manuel deleted the sc-480-dai-inflation-attack-test branch June 20, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexonaut hexonaut hexonaut approved these changes

@barrutko barrutko Awaiting requested review from barrutko

Assignees

@lucas-manuel lucas-manuel

Labels
Priority: Medium Status: Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucas-manuel @hexonaut