[SC-380] Improve Coverage + Slight Refactoring

foundry.toml

@@ -2,3 +2,6 @@
 src = "src"
 out = "out"
 libs = ["lib"]
+solc_version = '0.8.25'
+optimizer = true
+optimizer_runs = 200

src/executors/AuthBridgeExecutor.sol

@@ -3,7 +3,7 @@ pragma solidity ^0.8.10;
 
 import { AccessControl } from 'lib/openzeppelin-contracts/contracts/access/AccessControl.sol';
 
-import { IAuthBridgeExecutor } from '../interfaces/IAuthBridgeExecutor.sol';
+import { IAuthBridgeExecutor } from 'src/interfaces/IAuthBridgeExecutor.sol';
 import { BridgeExecutorBase }  from './BridgeExecutorBase.sol';
 
 /**

src/executors/BridgeExecutorBase.sol

@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: AGPL-3.0
 pragma solidity ^0.8.10;
 
-import { IExecutorBase } from '../interfaces/IExecutorBase.sol';
+import { IExecutorBase } from 'src/interfaces/IExecutorBase.sol';
 
 /**
  * @title BridgeExecutorBase

src/receivers/BridgeExecutorReceiverArbitrum.sol

@@ -1,9 +1,9 @@
-// SPDX-License-Identifier: AGPL-3.0-or-later
+// SPDX-License-Identifier: AGPL-3.0
 pragma solidity ^0.8.0;
 
 import { ArbitrumReceiver } from 'xchain-helpers/ArbitrumReceiver.sol';
 
-import { IAuthBridgeExecutor } from '../interfaces/IAuthBridgeExecutor.sol';
+import { IAuthBridgeExecutor } from 'src/interfaces/IAuthBridgeExecutor.sol';
 
 contract BridgeExecutorReceiverArbitrum is ArbitrumReceiver {
 

src/receivers/BridgeExecutorReceiverGnosis.sol

@@ -1,9 +1,9 @@
-// SPDX-License-Identifier: AGPL-3.0-or-later
+// SPDX-License-Identifier: AGPL-3.0
 pragma solidity ^0.8.0;
 
 import { GnosisReceiver } from 'xchain-helpers/GnosisReceiver.sol';
 
-import { IAuthBridgeExecutor } from '../interfaces/IAuthBridgeExecutor.sol';
+import { IAuthBridgeExecutor } from 'src/interfaces/IAuthBridgeExecutor.sol';
 
 contract BridgeExecutorReceiverGnosis is GnosisReceiver {
 

src/receivers/BridgeExecutorReceiverOptimism.sol

@@ -1,9 +1,9 @@
-// SPDX-License-Identifier: AGPL-3.0-or-later
+// SPDX-License-Identifier: AGPL-3.0
 pragma solidity ^0.8.0;
 
 import { OptimismReceiver } from 'xchain-helpers/OptimismReceiver.sol';
 
-import { IAuthBridgeExecutor } from '../interfaces/IAuthBridgeExecutor.sol';
+import { IAuthBridgeExecutor } from 'src/interfaces/IAuthBridgeExecutor.sol';
 
 contract BridgeExecutorReceiverOptimism is OptimismReceiver {
 

test/ArbitrumCrosschainTest.t.sol → test/ArbitrumOneCrosschainTest.t.sol

@@ -1,19 +1,19 @@
-// SPDX-License-Identifier: MIT
+// SPDX-License-Identifier: AGPL-3.0
 pragma solidity ^0.8.0;
 
 import 'forge-std/Test.sol';
 
 import { Domain, ArbitrumDomain } from 'xchain-helpers/testing/ArbitrumDomain.sol';
 import { XChainForwarders }       from 'xchain-helpers/XChainForwarders.sol';
 
-import { AuthBridgeExecutor }             from '../src/executors/AuthBridgeExecutor.sol';
-import { BridgeExecutorReceiverArbitrum } from '../src/receivers/BridgeExecutorReceiverArbitrum.sol';
+import { AuthBridgeExecutor }             from 'src/executors/AuthBridgeExecutor.sol';
+import { BridgeExecutorReceiverArbitrum } from 'src/receivers/BridgeExecutorReceiverArbitrum.sol';
 
 import { IPayload } from './interfaces/IPayload.sol';
 
 import { CrosschainPayload, CrosschainTestBase } from './CrosschainTestBase.sol';
 
-contract ArbitrumCrosschainPayload is CrosschainPayload {
+contract ArbitrumOneCrosschainPayload is CrosschainPayload {
 
     constructor(IPayload _targetPayload, address _bridgeReceiver)
         CrosschainPayload(_targetPayload, _bridgeReceiver) {}
@@ -30,12 +30,12 @@ contract ArbitrumCrosschainPayload is CrosschainPayload {
 
 }
 
-contract ArbitrumCrosschainTest is CrosschainTestBase {
+contract ArbitrumOneCrosschainTest is CrosschainTestBase {
 
     function deployCrosschainPayload(IPayload targetPayload, address bridgeReceiver)
         public override returns (IPayload)
     {
-        return IPayload(new ArbitrumCrosschainPayload(targetPayload, bridgeReceiver));
+        return IPayload(new ArbitrumOneCrosschainPayload(targetPayload, bridgeReceiver));
     }
 
     function setUp() public {
@@ -60,4 +60,14 @@ contract ArbitrumCrosschainTest is CrosschainTestBase {
         vm.deal(L1_EXECUTOR, 0.01 ether);
     }
 
+    function test_constructor_receiver() public {
+        BridgeExecutorReceiverArbitrum receiver = new BridgeExecutorReceiverArbitrum(
+            defaultL2BridgeExecutorArgs.ethereumGovernanceExecutor,
+            bridgeExecutor
+        );
+
+        assertEq(receiver.l1Authority(),       defaultL2BridgeExecutorArgs.ethereumGovernanceExecutor);
+        assertEq(address(receiver.executor()), address(bridgeExecutor));
+    }
+
 }