[SC-380] Improve Coverage + Slight Refactoring #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexonaut
added
Status: Ready for Review
Priority: High
and removed
Priority: Medium
Status: Work In Progress
labels
lucas-manuel
requested changes
May 15, 2024
lucas-manuel
added
Status: Revisions Needed
and removed
Status: Ready for Review
labels
barrutko
requested changes
May 16, 2024
lucas-manuel
requested changes
May 16, 2024
|
Coverage after merging SC-380-improve-coverage into master will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||
|
Fixed all outstanding issues. Re min/max delay: these provide no extra protection because the payload can just call |
lucas-manuel
approved these changes
May 17, 2024
barrutko
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A slight refactoring to the integration test naming, use absolute paths, fix license, add solidity compiler settings and writing unit tests for the business logic.
Please note I am purposefully excluding the min/max delay testing as I'm going to remove it in a subsequent PR since it provides no additional protection.