Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix <Datagrid rowClick> regression #10102

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Fix <Datagrid rowClick> regression #10102

merged 2 commits into from
Aug 2, 2024
+183 −117

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Jul 29, 2024

Problem

#10100

Additional Checks

  • The PR targets master for a bugfix, or next for a feature

@djhi djhi added the RFR Ready For Review label Jul 29, 2024
fzaninotto
fzaninotto requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The code is easier to read with this change 👍

packages/ra-core/src/routing/useGetPathForRecord.ts Outdated

return path;
};

export const useGetRouteForRecordCallback = <
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd call this function useGetRouteForRecordCallback and extract it to another file (and export it)

@fzaninotto fzaninotto merged commit 169f5f8 into master Aug 2, 2024
14 checks passed
@fzaninotto fzaninotto deleted the fix-datagrid-rowclick-regression branch August 2, 2024 09:21
@fzaninotto fzaninotto added this to the 5.1.1 milestone Aug 2, 2024
@fzaninotto fzaninotto mentioned this pull request Aug 2, 2024
Closed
@djhi djhi mentioned this pull request Dec 9, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwanMarmelab erwanMarmelab erwanMarmelab approved these changes

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
5.1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@djhi @fzaninotto @BrenoWii @erwanMarmelab