Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix <Datagrid> rowClick function cannot expand or select #10404

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Fix <Datagrid> rowClick function cannot expand or select #10404

merged 2 commits into from
Dec 9, 2024
+229 −114

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Dec 9, 2024

Problem

Fixes #10394

#10102 introduced a regression that prevents rowClick functions to return expand or toggleSelection

Solution

Fix the regression and add tests

How To Test

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

Also, please make sure to read the contributing guidelines.

slax57
slax57 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the isPromise helper! ❤️

@slax57 slax57 added this to the 5.4.2 milestone Dec 9, 2024
@slax57 slax57 merged commit 3e611ef into master Dec 9, 2024
15 checks passed
@slax57 slax57 deleted the fix-datagrid-row-click branch December 9, 2024 14:17
@BrenoWii
Copy link

BrenoWii commented Dec 9, 2024

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.4.2
Development

Successfully merging this pull request may close these issues.

Unexpected behavior in DataGrid when using 'rowClick' as a function for row expansion
3 participants
@djhi @BrenoWii @slax57