Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local bundle update #186

Closed
wants to merge 87 commits into from
Closed

Local bundle update #186

wants to merge 87 commits into from

Conversation

BrookRoberts
Copy link

Merge master into feature-local bundle, and fix both cases where shot.id needs to be converted to string (last commit)

Brook Roberts and others added 30 commits January 24, 2017 12:15
Allow pixel masks to be input on a per image basis
fd847c5
Change to storing masks as images with data in first channel
4108cd7
Tidying code
09fce39
Add feature to treat images as video series and only match nearby frames
b5b9259
Tidy up comment
2203d04
@paulinus
Merge pull request mapillary#133 from BrookRoberts/order_neighbors
ceacacc 
Image matching on consecutive images
@winsento
Add sensor width for DJI Phantom 4.
cca3886
@paulinus
Merge pull request mapillary#137 from winsento/master
97bcaaf 
Add sensor width for DJI Phantom 4.
@paulinus
Add option to plot matches between image subsets
bb91c69
@paulinus
Convert id to str when bundling with GPS
0abbe04
@paulinus
Use bilinear interpolation to remap panoramas
c4cbd49
@paulinus
Prevent opencv3 imread from using EXIF orientation
5fc86b9 
Fixes mapillary#135
@paulinus
Add fisheye camera model
06fe969
@paulinus
Handle fisheye io independently of perspective
7fad29b
@paulinus
Bundle adjust fisheye cameras
25ad5e6
Load masks from within the Dataset class
52abc4a
Switch to using 0 as the mask out value for per image masks
c1ed100
@paulinus
Handle fisheye cameras on the viewer
08eab36
@paulinus
Fix writing partial reconstructions
310f75d
@paulinus
Fix writing partial reconstructions
3cc44ec
@paulinus
Undistort fisheye images
62a4db0
@paulinus
Add failing fisheye projection test
88ceac3
@paulinus
Fix fisheye projection
b70e34c
@paulinus
Fix viewer's fisheye projection
13058fd
@paulinus
Fisheye cameras are of fisheye type 🙃
213adde
@paulinus
Convert fisheye to perspective cameras when undistorting
7333974
Fix name clash for masks in mask_and_normalize_features
225d570
@paulinus
Compute meshes for fisheyes
7181f4b
@paulinus
Merge pull request mapillary#132 from BrookRoberts/masks
217b49e 
Allow per image masking
@paulinus
Convert masks to 2D arrays
e894649
paulinus and others added 25 commits March 29, 2017 13:16
@paulinus
Merge pull request mapillary#154 from kachayev/patch-1
f642e49 
Update documentation to use virtualenv
@oscarlorentzon
Store and return best neighbor index.
7a0260d
@oscarlorentzon
Fix pytest setup-cfg section name warning.
12835bf
@oscarlorentzon
Initialize with single random neighbor.
f31246d
@oscarlorentzon
Randomly sample neighbors.
366e36c 
Use only current neighbor when checking random planes.
Propagate neighbor when checking neighboring pixel planes.
Randomly sample another neighbor after all other
tests.
@oscarlorentzon
Include headers for depth where used.
7ec1034
@oscarlorentzon
Save neighbour matrix and list in dataset.
40c0118
@oscarlorentzon
Rename image plane check overload for clarity.
64b7a4e
@oscarlorentzon
Add script for plotting saved raw depthmaps.
1fa98d9
@oscarlorentzon
Rename neighbor variables.
e584deb
@oscarlorentzon
Add method for running patch match with sampling.
8e341c4 
Make it possible to run either regular patch match or
patch match with single view sampling.
@oscarlorentzon
Add config param for choosing depthmap algorithm.
ee7987d
@oscarlorentzon
Use references instead of returning pair.
89629ed
@oscarlorentzon
Throw if depthmap method is not supported.
ddf710c 
Throw to make it clear what depthmap methods are supported.
Do not use defualt param values.
Rename pixel neighbor to adjacent for clarity.
@oscarlorentzon
Refactor pixel assignment to method.
9bd7e4a
@oscarlorentzon
Use pointers for return values.
079608d
@paulinus
Catch division by zero when parsing EXIF
24ee416 
Fixes mapillary#85
@paulinus
Save features in the features folder.
a01c0bb 
Do not use the name of the features for naming the features folder and files
@paulinus
Add commands description
fe5c5ff
@paulinus
Update openmvs Interface.h
77d21a4 
Close mapillary#169
@paulinus
Open binary files in binary mode.
0d87840 
Fixes mapillary#171
@paulinus
Remove old run_all (replaced by opensfm_run_all)
c230ce4
@paulinus
Better resolution fit when undistorting panoramas
32dc83f
Merge remote-tracking branch 'remotes/upstream/master' into HEAD
abe41ac
Convert shot.id to string as required by bundle adjuster
833f74c
@paulinus
Copy link
Member

@BrookRoberts does this merge include the incremental matching of this other PR #178

I'll merge master to feature-local-bundle independently first and then see what are the remaining differences with BrookRoberts/feature-local-bundle.

@BrookRoberts
Copy link
Author

@paulinus I wasn't intending it to. I'm currently using local-bundle for somethings, and noticed it was quite a bit off master.

@paulinus paulinus closed this Jun 19, 2017
@paulinus
Copy link
Member

I've merged the branch to master so that it does not go off anymore.
Added a parameter in config to use the local bundle feature so that it is off by default

@BrookRoberts BrookRoberts deleted the local-bundle-update branch June 19, 2017 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@BrookRoberts @paulinus @xialang2012 @winsento @merkato @EmbeddedAndroid @kachayev @oscarlorentzon