Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(hash): Use new hash map #66

Merged
merged 5 commits into from
Jul 9, 2024
Merged

perf(hash): Use new hash map #66

merged 5 commits into from
Jul 9, 2024

Conversation

malik672
Copy link
Owner

@malik672 malik672 commented Jul 3, 2024

implement a faster hashmap
bump to 1.0.0

@malik672 malik672 added the enhancement New feature or request label Jul 3, 2024
@malik672 malik672 requested a review from shuhuiluo July 3, 2024 14:30
Copy link
Collaborator

@shuhuiluo shuhuiluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix linting.

Cargo.toml Outdated
@@ -1,6 +1,6 @@
[package]
name = "uniswap-sdk-core"
version = "0.23.0"
version = "1.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not jump to 1.0.0 rn. I will have a PR updating dependencies.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Collaborator

@shuhuiluo shuhuiluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove missing_docs attribute to fix linting.

@shuhuiluo shuhuiluo changed the title new_hash perf(hash): Use new hash map Jul 7, 2024
@malik672 malik672 requested a review from shuhuiluo July 9, 2024 03:03
Cargo.toml Outdated Show resolved Hide resolved
@malik672 malik672 requested a review from shuhuiluo July 9, 2024 03:09
@malik672 malik672 merged commit db82793 into master Jul 9, 2024
2 checks passed
@malik672 malik672 deleted the new_hash branch July 9, 2024 03:24
@shuhuiluo
Copy link
Collaborator

Please use squash merge to keep the main branch clean.

@shuhuiluo shuhuiluo linked an issue Jul 9, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a faster HashMap crate
2 participants