Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a faster HashMap crate #62

Closed
shuhuiluo opened this issue Apr 7, 2024 · 4 comments · Fixed by #60 or #66
Closed

Use a faster HashMap crate #62

shuhuiluo opened this issue Apr 7, 2024 · 4 comments · Fixed by #60 or #66
Assignees
@malik672
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@shuhuiluo
Copy link
Collaborator

I don't think hash collision is a concern for this crate. Consider using a faster HashMap impl than std::collections::HashMap.

Reference:
https://nnethercote.github.io/perf-book/hashing.html
https://nnethercote.github.io/perf-book/linting.html#disallowing-types
@shuhuiluo shuhuiluo added enhancement New feature or request good first issue Good for newcomers labels Apr 7, 2024
@malik672
Copy link
Owner

on it, btw should we make this crate wasm compartible

@shuhuiluo
Copy link
Collaborator Author

on it, btw should we make this crate wasm compartible

We can. Should be compatible after getting rid of std?

@malik672
Copy link
Owner

on it, btw should we make this crate wasm compartible

We can. Should be compatible after getting rid of std?

yeah, this will take a lot of refactoring

@malik672 malik672 linked a pull request Apr 13, 2024 that will close this issue
chore(doc): Add comments and derive attributes #60
Merged
@shuhuiluo shuhuiluo reopened this Jun 29, 2024
@malik672
Copy link
Owner

FxHashMap

@shuhuiluo shuhuiluo linked a pull request Jul 9, 2024 that will close this issue
perf(hash): Use new hash map #66
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malik672 malik672

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@malik672 @shuhuiluo