Fix string encoding issues #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SvPVutf8 is a macro...
Not too sure about this one ... while bytes_to_utf8 is "experimental" according to perlapi, it isn't labelled as such in perlguts, which actually recommends using it for our exact scenario. bytes_to_utf8 was introduced in Perl 5.7.0, so it's been around like forever and it seems unlikely that it would suddenly vanish. And avoiding bytes_to_utf8 in the way this change does uses up more (temp) memory. In spite of all that, using "experimental" functions seems like a bad idea to me. newSVpvn_flags is available from Perl 5.10.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38, fixes #39.
As a result of resolving #38, REST::Neo4p’s
rt_91640.tpasses when run over Bolt; see majensen/rest-neo4p#29 (comment).Both of the issues resolved by this PR only occur in what I believe to be somewhat rare situations. IMHO releasing this to CPAN is not urgent at all.