Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid use of experimental bytes_to_utf8
Not too sure about this one ... while bytes_to_utf8 is "experimental" according to perlapi, it isn't labelled as such in perlguts, which actually recommends using it for our exact scenario. bytes_to_utf8 was introduced in Perl 5.7.0, so it's been around like forever and it seems unlikely that it would suddenly vanish. And avoiding bytes_to_utf8 in the way this change does uses up more (temp) memory. In spite of all that, using "experimental" functions seems like a bad idea to me. newSVpvn_flags is available from Perl 5.10.1.
- Loading branch information
8b706f9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change doesn’t seem to have any measurable performance impact.