Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pr-format-check.yml action #70

Merged
merged 29 commits into from
Mar 30, 2024
Merged

Conversation

Micnasr
Copy link
Contributor

@Micnasr Micnasr commented Mar 21, 2024

Github Action to block merging if code does not follow proper repo formatting rules.

Closes #38

Sorry for the billion commits, no other way to test it the github actions gets triggered on a PR & its terminal is not the same as my local one.

Testing:
No Changes -> Passes
Changes with Bad Formatting -> Fails
Changes with Good Formatting -> Passes

samparent97
samparent97 previously approved these changes Mar 21, 2024
Copy link
Contributor

@samparent97 samparent97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@BlakeFreer
Copy link
Contributor

Good use of the --diff flag

@BlakeFreer BlakeFreer closed this Mar 21, 2024
@BlakeFreer BlakeFreer reopened this Mar 21, 2024
BlakeFreer
BlakeFreer previously approved these changes Mar 21, 2024
@BlakeFreer BlakeFreer linked an issue Mar 21, 2024 that may be closed by this pull request
@Micnasr Micnasr dismissed stale reviews from BlakeFreer and samparent97 via cb36611 March 23, 2024 06:00
BlakeFreer
BlakeFreer previously approved these changes Mar 23, 2024
@BlakeFreer BlakeFreer merged commit a0b34f6 into main Mar 30, 2024
1 check passed
@BlakeFreer BlakeFreer deleted the user/micnasr/format-check branch March 30, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Github action for blocking merge without clang format
3 participants