-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create pr-format-check.yml action #70
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Micnasr
requested review from
samparent97,
BlakeFreer,
tullom and
clarawong20
as code owners
March 21, 2024 03:30
samparent97
previously approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Good use of the |
BlakeFreer
previously approved these changes
Mar 21, 2024
…ecar into user/micnasr/format-check
BlakeFreer
previously approved these changes
Mar 23, 2024
…ecar into user/micnasr/format-check
samparent97
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Action to block merging if code does not follow proper repo formatting rules.
Closes #38
Sorry for the billion commits, no other way to test it the github actions gets triggered on a PR & its terminal is not the same as my local one.
Testing:
No Changes -> Passes
Changes with Bad Formatting -> Fails
Changes with Good Formatting -> Passes