Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github action for blocking merge without clang format #38

Closed
samparent97 opened this issue Jan 20, 2024 · 1 comment · Fixed by #70
Closed

Add Github action for blocking merge without clang format #38

samparent97 opened this issue Jan 20, 2024 · 1 comment · Fixed by #70
Assignees
Labels
enhancement New feature or request

Comments

@samparent97
Copy link
Contributor

No description provided.

@BlakeFreer
Copy link
Contributor

BlakeFreer commented Feb 5, 2024

We should use git-clang-format instead of the regular clang-format to avoid formatting otherwise unmodified code. This means that sections of code will not be formatted until an actual modification is performed, but it will maintain our commit history.

See this article for a more detailed explanation https://ortogonal.github.io/cpp/git-clang-format/

Also see #69

@BlakeFreer BlakeFreer added the enhancement New feature or request label Mar 19, 2024
@BlakeFreer BlakeFreer linked a pull request Mar 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants