added setLocation function #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonStalnaker
force-pushed
the
feature/setLocationAddition
branch
from
91d9cbb to
e7ba93e
Compare
|
@AjilJagadeesh7 - Thank you for the PR! I've tested this locally and I am able to see the latitude and longitude show up in our live stream in a test app for both iOS/Android. I do see some tests breaking, so I'll put a commit up for that to move this along, and work with my coworker @BrandonStalnaker to approve and get this through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
{provide a thorough description of the changes}
Testing Plan
{explain how this has been tested, and what additional testing should be done}
Master Issue
Closes https://go.mparticle.com/work/REPLACEME