updated pr based on comments | split location to latitude and longitude

mParticle · Mar 12, 2024 · e7ba93e · e7ba93e
1 parent aab1956
commit e7ba93e
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/android/src/main/java/com/mparticle/react/MParticleModule.java b/android/src/main/java/com/mparticle/react/MParticleModule.java
@@ -1,5 +1,6 @@
 package com.mparticle.react;
 
+import android.location.Location;
 import android.util.Log;
 
 import com.facebook.react.bridge.Arguments;
@@ -74,8 +75,12 @@ public void setUploadInterval(int uploadInterval) {
     }
 
     @ReactMethod
-    public void setLocation(final android.location.Location location) {
-        MParticle.getInstance().setLocation(location);
+    public void setLocation(double latitude, double longitude) {
+        Location newLocation = new Location(""); 
+        newLocation.setLatitude(latitude);
+        newLocation.setLongitude(longitude);
+        MParticle.getInstance().setLocation(newLocation);
+
     }
 
     @ReactMethod

diff --git a/ios/RNMParticle/RNMParticle.m b/ios/RNMParticle/RNMParticle.m
@@ -30,8 +30,9 @@ + (void)load {
     [[MParticle sharedInstance] upload];
 }
 
-RCT_EXPORT_METHOD(setLocation:(CLLocation *)newLocation)
+RCT_EXPORT_METHOD(setLocation:(double)latitude longitude:(double)longitude)
 {
+    CLLocation *newLocation = [[CLLocation alloc] initWithLatitude:latitude longitude:longitude];
     [MParticle sharedInstance].location = newLocation;    
 }
 

diff --git a/js/index.js b/js/index.js
@@ -158,8 +158,8 @@ const getSession = (completion) => {
   NativeModules.MParticle.getSession(completion)
 }
 
-const setLocation = (location) => {
-  NativeModules.MParticle.setLocation(location);
+const setLocation = (latitude, longitude) => {
+  NativeModules.MParticle.setLocation(latitude, longitude);
 };
 
 // ******** Identity ********