Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45722: CRITICAL logs on empty quantum graph #441

Merged
merged 1 commit into from
Aug 29, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions python/lsst/pipe/base/all_dimensions_quantum_graph_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -532,14 +532,14 @@
# put these args in an easier-to-reconstruct equivalent form
# so they can read it more easily and copy and paste into
# a Python terminal.
buffer.write(f" dimensions={list(self.query_args['dimensions'].names)},")
buffer.write(f" dataId={dict(self.query_args['dataId'].required)},")
buffer.write(f" dimensions={list(self.query_args['dimensions'].names)},\n")
buffer.write(f" dataId={dict(self.query_args['dataId'].required)},\n")

Check warning on line 536 in python/lsst/pipe/base/all_dimensions_quantum_graph_builder.py

View check run for this annotation

Codecov / codecov/patch

python/lsst/pipe/base/all_dimensions_quantum_graph_builder.py#L535-L536

Added lines #L535 - L536 were not covered by tests
if self.query_args["where"]:
buffer.write(f" where={repr(self.query_args['where'])},")
buffer.write(f" where={repr(self.query_args['where'])},\n")

Check warning on line 538 in python/lsst/pipe/base/all_dimensions_quantum_graph_builder.py

View check run for this annotation

Codecov / codecov/patch

python/lsst/pipe/base/all_dimensions_quantum_graph_builder.py#L538

Added line #L538 was not covered by tests
if "datasets" in self.query_args:
buffer.write(f" datasets={list(self.query_args['datasets'])},")
buffer.write(f" datasets={list(self.query_args['datasets'])},\n")

Check warning on line 540 in python/lsst/pipe/base/all_dimensions_quantum_graph_builder.py

View check run for this annotation

Codecov / codecov/patch

python/lsst/pipe/base/all_dimensions_quantum_graph_builder.py#L540

Added line #L540 was not covered by tests
if "collections" in self.query_args:
buffer.write(f" collections={list(self.query_args['collections'])},")
buffer.write(f" collections={list(self.query_args['collections'])},\n")

Check warning on line 542 in python/lsst/pipe/base/all_dimensions_quantum_graph_builder.py

View check run for this annotation

Codecov / codecov/patch

python/lsst/pipe/base/all_dimensions_quantum_graph_builder.py#L542

Added line #L542 was not covered by tests
finally:
# If an exception was raised, write a partial.
log.error(buffer.getvalue())
Expand Down
Loading