Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45722: CRITICAL logs on empty quantum graph #441

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

kfindeisen
Copy link
Member

@kfindeisen kfindeisen commented Aug 29, 2024

This PR fixes a display bug introduced in #440, where the reformatted logs were being printed without line breaks at all.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

The logs were accidentally committed without line breaks.
@kfindeisen kfindeisen requested a review from TallJimbo August 29, 2024 17:23
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.15%. Comparing base (c68239a) to head (43d65ed).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../pipe/base/all_dimensions_quantum_graph_builder.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #441   +/-   ##
=======================================
  Coverage   81.15%   81.15%           
=======================================
  Files          96       96           
  Lines       10937    10937           
  Branches     2086     2086           
=======================================
  Hits         8876     8876           
  Misses       1703     1703           
  Partials      358      358           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kfindeisen kfindeisen merged commit b007c62 into main Aug 29, 2024
12 of 13 checks passed
@kfindeisen kfindeisen deleted the tickets/DM-45722-hotfix branch August 29, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants