Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-46388: Add STREAK to default mask planes #754

Merged
merged 1 commit into from
Dec 4, 2024
Merged

DM-46388: Add STREAK to default mask planes #754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions include/lsst/afw/image/Mask.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ using MaskPlaneDict = std::map<std::string, int>;
* input exposures.
* - `VIGNETTED` This pixel is in a vignetted region; exactly how much vignetting is set by the downstream
* processing code.
* - `STREAK` This pixel is part of a long linear feature, possibly a satellite or fast-moving asteroid.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not bad! However, I'd prefer not to explicitly call out "satellite," to avoid people who may be particular about such things. Perhaps "This pixel is part of a long linear and likely non-astrophysical feature."?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the streak isn't going to be in our released AP images, and it won't matter whether it is in the DRP images (since they're after the 80 hour embargo), I don't think that's a problem? Do you really think we shouldn't mention satellites in our docs at all?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others have bent over backwards to not say "satellite" so I am mostly suggesting we follow that unwritten precedent. It's not a big deal to me either way.

*/
template <typename MaskPixelT = lsst::afw::image::MaskPixel>
class Mask : public ImageBase<MaskPixelT> {
Expand Down
1 change: 1 addition & 0 deletions src/image/detail/MaskDict.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ void MaskDict::_addInitialMaskPlanes() {
_dict["SUSPECT"] = ++i;
_dict["NO_DATA"] = ++i;
_dict["VIGNETTED"] = ++i;
_dict["STREAK"] = ++i;
_hash = boost::hash<MaskPlaneDict>()(_dict);
}

Expand Down
Loading