DM-46388: Add STREAK to default mask planes #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrawls
approved these changes
Nov 27, 2024
| @@ -76,6 +76,7 @@ using MaskPlaneDict = std::map<std::string, int>; | |||
| * input exposures. | |||
| * - `VIGNETTED` This pixel is in a vignetted region; exactly how much vignetting is set by the downstream | |||
| * processing code. | |||
| * - `STREAK` This pixel is part of a long linear feature, possibly a satellite or fast-moving asteroid. | |||
There was a problem hiding this comment.
Not bad! However, I'd prefer not to explicitly call out "satellite," to avoid people who may be particular about such things. Perhaps "This pixel is part of a long linear and likely non-astrophysical feature."?
There was a problem hiding this comment.
Since the streak isn't going to be in our released AP images, and it won't matter whether it is in the DRP images (since they're after the 80 hour embargo), I don't think that's a problem? Do you really think we shouldn't mention satellites in our docs at all?
There was a problem hiding this comment.
Others have bent over backwards to not say "satellite" so I am mostly suggesting we follow that unwritten precedent. It's not a big deal to me either way.
parejkoj
force-pushed
the
tickets/DM-46388
branch
from
93d7373 to
a6f86e7
Compare
parejkoj
force-pushed
the
tickets/DM-46388
branch
from
a6f86e7 to
5ac7a82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.