-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
119 adler demo #120
119 adler demo #120
Conversation
…e into the demo Merge branch '106-outlying-photometry-checker' into 119-adler-demo
Merge branch 'main' into 119-adler-demo
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
==========================================
+ Coverage 84.71% 89.35% +4.63%
==========================================
Files 14 17 +3
Lines 373 545 +172
==========================================
+ Hits 316 487 +171
- Misses 57 58 +1 ☔ View full report in Codecov by Sentry. |
Bare minimum added to test_AdlerCLIArguments.py to get the new sql_fname CLI option to not break the existing unit tests. This option will need inspected and properly unit tested. |
And I should probably explain, I added a new CLI option: This makes a start at addressing issue #111 |
@astronomerritt would be great to get you review on this one, particularly the addition of sql_filename to the CLI. Also the demo version of running the adler command will fail if the |
Fixes #119 .
Uses the outlier detection functions from PR #113 within the adler CLI to demonstrate the identification of outlying photometry compared to a phase curve model for a given object.
Review Checklist for Source Code Changes