Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

119 adler demo #120

Merged
merged 22 commits into from
May 22, 2024
Merged

119 adler demo #120

merged 22 commits into from
May 22, 2024

Conversation

jrob93
Copy link
Collaborator

@jrob93 jrob93 commented May 14, 2024

Fixes #119 .

Uses the outlier detection functions from PR #113 within the adler CLI to demonstrate the identification of outlying photometry compared to a phase curve model for a given object.

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does adler run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

jrob93 added 2 commits May 14, 2024 09:58
…e into the demo

Merge branch '106-outlying-photometry-checker' into 119-adler-demo
@jrob93 jrob93 linked an issue May 14, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 70.83333% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 89.35%. Comparing base (7f0094b) to head (436cdeb).
Report is 55 commits behind head on main.

❗ Current head 436cdeb differs from pull request most recent head 1e71996. Consider uploading reports for the commit 1e71996 to get more accurate results

Files Patch % Lines
src/adler/utilities/science_utilities.py 70.83% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   84.71%   89.35%   +4.63%     
==========================================
  Files          14       17       +3     
  Lines         373      545     +172     
==========================================
+ Hits          316      487     +171     
- Misses         57       58       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrob93
Copy link
Collaborator Author

jrob93 commented May 17, 2024

Bare minimum added to test_AdlerCLIArguments.py to get the new sql_fname CLI option to not break the existing unit tests. This option will need inspected and properly unit tested.

@jrob93
Copy link
Collaborator Author

jrob93 commented May 17, 2024

And I should probably explain, I added a new CLI option:
-i SQL_FILENAME, --sql_filename SQL_FILENAME Optional input path location of a sql database file containing observations
When this option is provided, it triggers adler to retrieve observations using AdlerPlanetoid.construct_from_SQL rather than AdlerPlanetoid.construct_from_RSP.

This makes a start at addressing issue #111

@jrob93 jrob93 marked this pull request as ready for review May 21, 2024 16:14
@jrob93 jrob93 requested a review from astronomerritt May 21, 2024 16:20
@jrob93
Copy link
Collaborator Author

jrob93 commented May 21, 2024

@astronomerritt would be great to get you review on this one, particularly the addition of sql_filename to the CLI. Also the demo version of running the adler command will fail if the data and plots directories are not there for the output files to be saved, not sure how to deal with that right now.

@astronomerritt astronomerritt merged commit 4f103db into main May 22, 2024
10 checks passed
@jrob93 jrob93 mentioned this pull request May 22, 2024
@jrob93 jrob93 deleted the 119-adler-demo branch December 4, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adler demo
3 participants