Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phase curve bounds #132

Closed
jrob93 opened this issue May 16, 2024 · 1 comment
Closed

phase curve bounds #132

jrob93 opened this issue May 16, 2024 · 1 comment
Assignees

Comments

@jrob93
Copy link
Collaborator

jrob93 commented May 16, 2024

By default the sbpy phase curve models have bounds set on the phase parameter, which limits the fitter to these values. We probably want an option to disable these bounds, e.g. for an adler PhaseCurve object pc:
pc.model_function.G12.bounds = (None,None)

N.B. that bounds may be necessary in some cases, e.g. the sbpy HG model and astropy LevMarLSQFitter will fail without bounds when very high phase angle data is included in the fit (see example object ssoid = 8268570668335894776)

@jrob93 jrob93 self-assigned this May 16, 2024
@jrob93
Copy link
Collaborator Author

jrob93 commented May 22, 2024

This was closed by #120

@jrob93 jrob93 closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant