Skip to content

use NON_EMPTY include

This check has been archived and is scheduled for deletion. Learn more about checks retention
Teamscale / teamscale-findings required action Sep 15, 2023

Teamscale

This pull request would introduce 9 new findings

Details

Teamscale's logo 9 added, 46 in changed code, 4 removed 37 Test Gaps (100%) tested changes: 0|untested changes: 25|untested additions: 12

  • src/main/java/de/tum/in/www1/artemis/web/rest/dto/ParticipationDTO.java#10: Interface comment missing (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/web/rest/dto/ParticipationDTO.java#8: Interface comment missing (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/web/rest/dto/ResultDTO.java#27: Interface comment missing (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/web/rest/dto/DomainObjectIdDTO.java#10: Interface comment missing (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/web/rest/dto/ResultDTO.java#24: Interface comment missing (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/domain/participation/Participation.java#325: Interface comment missing (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/web/rest/dto/DomainObjectIdDTO.java#8: Interface comment missing (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/web/rest/dto/ResultDTO.java#34: Interface comment missing (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/web/rest/dto/ResultDTO.java#12: Star import of de.tum.in.www1.artemis.domain.enumeration.* should not be used (view in Teamscale)

Annotations

Check warning on line 10 in src/main/java/de/tum/in/www1/artemis/web/rest/dto/ParticipationDTO.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/web/rest/dto/ParticipationDTO.java#L10 

Interface comment missing
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=chore%2FnewResult-websocket-dto%3AHEAD&id=00896AF87AE92C1D3F7706D934540D0F

Check warning on line 8 in src/main/java/de/tum/in/www1/artemis/web/rest/dto/ParticipationDTO.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/web/rest/dto/ParticipationDTO.java#L8 

Interface comment missing
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=chore%2FnewResult-websocket-dto%3AHEAD&id=E2E79E770577D60B5957E8DAB372E3C7

Check warning on line 27 in src/main/java/de/tum/in/www1/artemis/web/rest/dto/ResultDTO.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/web/rest/dto/ResultDTO.java#L27 

Interface comment missing
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=chore%2FnewResult-websocket-dto%3AHEAD&id=123B5D13EC7ECF732E6BE0E06DC844FB

Check warning on line 25 in src/main/java/de/tum/in/www1/artemis/web/rest/dto/ResultDTO.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/web/rest/dto/ResultDTO.java#L24-L25 

Interface comment missing
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=chore%2FnewResult-websocket-dto%3AHEAD&id=429727A539B09642D97F4132479B9324

Check warning on line 12 in src/main/java/de/tum/in/www1/artemis/web/rest/dto/ResultDTO.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/web/rest/dto/ResultDTO.java#L12 

Star import of `de.tum.in.www1.artemis.domain.enumeration.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=chore%2FnewResult-websocket-dto%3AHEAD&id=519573F91DC4B316E0B8371A36760489

Check warning on line 34 in src/main/java/de/tum/in/www1/artemis/web/rest/dto/ResultDTO.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/web/rest/dto/ResultDTO.java#L34 

Interface comment missing
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=chore%2FnewResult-websocket-dto%3AHEAD&id=97BF853E00B69A00C80CDC151EF7E508

Check warning on line 8 in src/main/java/de/tum/in/www1/artemis/web/rest/dto/DomainObjectIdDTO.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/web/rest/dto/DomainObjectIdDTO.java#L8 

Interface comment missing
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=chore%2FnewResult-websocket-dto%3AHEAD&id=CCB0D47045FE330C619A0A52ABB5A82F

Check warning on line 10 in src/main/java/de/tum/in/www1/artemis/web/rest/dto/DomainObjectIdDTO.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/web/rest/dto/DomainObjectIdDTO.java#L10 

Interface comment missing
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=chore%2FnewResult-websocket-dto%3AHEAD&id=DDD2965255F519D1DDADC6D16D6D9F3F

Check warning on line 325 in src/main/java/de/tum/in/www1/artemis/domain/participation/Participation.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/domain/participation/Participation.java#L325 

In this file 11 interface comments are missing. Consider adding explanatory comments or restricting the visibility.

View in Teamscale:
https://teamscale.io/activity.html#details/GitHub-ls1intum-Artemis?t=chore%2FnewResult-websocket-dto%3A1694784623000
View more details on Teamscale