Skip to content

Commit

Permalink
use NON_EMPTY include
Browse files Browse the repository at this point in the history
  • Loading branch information
Strohgelaender committed Sep 15, 2023
1 parent d45180b commit efd78ec
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
package de.tum.in.www1.artemis.web.rest.dto;

import com.fasterxml.jackson.annotation.JsonInclude;

import de.tum.in.www1.artemis.domain.participation.Participation;

@JsonInclude(JsonInclude.Include.NON_EMPTY)
public record ParticipationDTO(Long id, boolean testRun, String type) {

Check warning on line 8 in src/main/java/de/tum/in/www1/artemis/web/rest/dto/ParticipationDTO.java

View check run for this annotation

Teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/web/rest/dto/ParticipationDTO.java#L8

Interface comment missing https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=chore%2FnewResult-websocket-dto%3AHEAD&id=E2E79E770577D60B5957E8DAB372E3C7

Check notice on line 8 in src/main/java/de/tum/in/www1/artemis/web/rest/dto/ParticipationDTO.java

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

src/main/java/de/tum/in/www1/artemis/web/rest/dto/ParticipationDTO.java#L8

Avoid variables with short names like id

public static ParticipationDTO of(Participation participation) {

Check warning on line 10 in src/main/java/de/tum/in/www1/artemis/web/rest/dto/ParticipationDTO.java

View check run for this annotation

Teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/web/rest/dto/ParticipationDTO.java#L10

Interface comment missing https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=chore%2FnewResult-websocket-dto%3AHEAD&id=00896AF87AE92C1D3F7706D934540D0F

Check notice on line 10 in src/main/java/de/tum/in/www1/artemis/web/rest/dto/ParticipationDTO.java

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

src/main/java/de/tum/in/www1/artemis/web/rest/dto/ParticipationDTO.java#L10

Avoid using short method names
Expand Down

0 comments on commit efd78ec

Please sign in to comment.