Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exam mode: Improve usability and readability of results summary #7204

Merged
merged 108 commits into from
Sep 24, 2023

Conversation

florian-glombik
Copy link
Contributor

@florian-glombik florian-glombik commented Sep 15, 2023

Checklist

General

Client

  • I followed the coding and design guidelines.
    Did not find a better alternative to "Prüfungsteilnehmer:in"
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
  • I documented the TypeScript code using JSDoc style, wherever the method name is not self-explanatory.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Motivation and Context

Resolves #7203

Description

Exam Mode Testing

Prerequisites:

  • 1 Instructor
  • 1 Students (You can also view the Student Submission as instructor, then you do not need to use a student)
  • 1 Exam with all exercise types (Programming, Quiz, Modelling, FileUpload, Text)
  1. student: participate in the exam, see that the confirmation screen appearance has changed
  2. student: view the ungraded summary directly after participating in an exam
  3. instructor: start and participate in a test run exam -> the start page and summary are relevant
  4. student: view the summary with a graded participation
    a) the general information should be easier to understand
    b) the result overview should link to the exercises (onClick -> scrolling to exercise)
    c) the grading keys should be collapsable (and no links to other pages)
    d) readable in darkmode
    e) the grading scale button is not visible if no grading scale exists
    d) the bonus grading scale button is not visible of no bonus grading scale exists
  5. instructor: the grading key table is still displayed properly when accessed as page

Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

Test Coverage

Class/File Line Coverage Confirmation (assert/expect)
exam-result-overview.component.ts 94.23%
participation.utils.ts 71.11%
updating-result.component.ts 98.24%
grading-key-helper.ts 100%
grading-key-overview.component.ts 100%
grading-key-table.component.ts 98.03%

Screenshots

Before After
exam cover page after exam cover page before
exam summary before exam cover page before exam cover page before

@florian-glombik florian-glombik added enhancement client Pull requests that update TypeScript code. (Added Automatically!) component:Exam Mode labels Sep 15, 2023
@florian-glombik florian-glombik added this to the 6.5.1 milestone Sep 15, 2023
@florian-glombik florian-glombik self-assigned this Sep 15, 2023
@github-actions github-actions bot added tests server Pull requests that update Java code. (Added Automatically!) database Pull requests that update the database. (Added Automatically!). Require a CRITICAL deployment. config-change Pull requests that change the config in a way that they require a deployment via Ansible. template and removed documentation labels Sep 17, 2023
@florian-glombik florian-glombik force-pushed the enhancement/exam/review-page branch from 139cb49 to 7f20287 Compare September 19, 2023 12:54
julian-christl
julian-christl previously approved these changes Sep 22, 2023
Copy link
Member

@julian-christl julian-christl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS2, all looks good now. Thanks for implementing the changes!

@florian-glombik florian-glombik changed the title Exam Mode: Improve usability and readability of results summary Exam mode: Improve usability and readability of results summary Sep 22, 2023
@florian-glombik
Copy link
Contributor Author

The misleading description within the bonus grading key table is known and will be addressed in a follow-up PR - this issue does already exist on develop.

image

Copy link
Contributor

@Strohgelaender Strohgelaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-tested on TS2, I did not find any issues and the new look is quite improved.

In a followup we might improve this tooltip, I think it should be much simpler for students (e.g. just ' You did not participate in this course').

code looks good to me as well.
grafik

Copy link
Collaborator

@MaximilianAnzinger MaximilianAnzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've some suggestions.

Copy link

@YeetTheFirst21 YeetTheFirst21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested on TS2,

looks really nice as long as the student name or course name is not very long

@JohannesStoehr JohannesStoehr changed the title Exam mode: Improve usability and readability of results summary Exam mode: Improve usability and readability of results summary Sep 23, 2023
@krusche krusche merged commit 05af462 into develop Sep 24, 2023
19 of 31 checks passed
@krusche krusche deleted the enhancement/exam/review-page branch September 24, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) component:Exam Mode enhancement ready for review tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exam Mode: Improve review page
7 participants