-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exam mode
: Improve usability and readability of results summary
#7204
Conversation
…for consistent naming
139cb49
to
7f20287
Compare
…trieve icons once
…tTextColorClassByExercise
…owResultOverview()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS2, all looks good now. Thanks for implementing the changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've some suggestions.
...main/webapp/app/exam/participate/summary/result-overview/exam-result-overview.component.scss
Show resolved
Hide resolved
src/main/webapp/app/exam/participate/general-information/exam-general-information.component.ts
Show resolved
Hide resolved
src/test/javascript/spec/component/grading-system/grading-key-table.component.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retested on TS2,
looks really nice as long as the student name or course name is not very long
Exam mode
: Improve usability and readability of results summary
Checklist
General
Client
Did not find a better alternative to "Prüfungsteilnehmer:in"
Motivation and Context
Resolves #7203
Description
Exam Mode Testing
Prerequisites:
a) the general information should be easier to understand
b) the result overview should link to the exercises (onClick -> scrolling to exercise)
c) the grading keys should be collapsable (and no links to other pages)
d) readable in darkmode
e) the grading scale button is not visible if no grading scale exists
d) the bonus grading scale button is not visible of no bonus grading scale exists
Review Progress
Performance Review
Code Review
Manual Tests
Exam Mode Test
Test Coverage
Screenshots