Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Fix e2e tests for exam information pages #7269

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

florian-glombik
Copy link
Contributor

@florian-glombik florian-glombik commented Sep 26, 2023

Checklist

General

  • I tested all changes and their related features with all corresponding user types on a test server.
  • This is a small issue that I tested locally and was confirmed by another developer on a test server.
  • I chose a title conforming to the naming conventions for pull requests.

Client

Motivation and Context

Currently, the Cypress E2E Tests are failing because in #7204 the actual exam title was removed from the dom element exam-title.
This PR shall fix the issue.

Description

Adding the exam title to the general information of an exam to fix the tests.
(Also a very small change fixing misaligned styling of a badge)

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 1 Students
  • 1 Exam with 33.3333333% of total achieved points (e.g. a text exercise with 1/3 points)
  1. Verify that E2E tests are not failing anymore
  2. Navigate to the Exam cover page and see that the exam title is displayed in the general information overview
  3. Navigate to the student review page and see that the exam title is displayed in the general information overview
  4. Verify that the total achieved percentage is rounded according to the course settings

Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

Screenshots

Rounding points

Before After
exam cover page after exam cover page before

Aligning test exam badge & displaying exam title

Before After

@florian-glombik florian-glombik added client Pull requests that update TypeScript code. (Added Automatically!) component:Exam Mode small labels Sep 26, 2023
@florian-glombik florian-glombik requested a review from a team as a code owner September 26, 2023 02:32
@florian-glombik florian-glombik self-assigned this Sep 26, 2023
@florian-glombik florian-glombik added this to the 6.5.3 milestone Sep 26, 2023
@krusche krusche changed the title Exam mode: Adding exam title to general information Development: Fix e2e tests for exam information pages Sep 26, 2023
@krusche krusche merged commit 66370ee into develop Sep 26, 2023
18 of 22 checks passed
@krusche krusche deleted the bugfix/fix-cypress-exam-id-check branch September 26, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix client Pull requests that update TypeScript code. (Added Automatically!) component:Exam Mode small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants