Communication: Accept messaging code of conduct

[nityanandaz]

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Server

• Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
• I followed the coding and design guidelines.
• I added multiple integration tests (Spring) related to the features (with a high test coverage).
• I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
• I documented the Java code using JavaDoc style.

Client

• Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
• I followed the coding and design guidelines.
• Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
• I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
• I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
• I documented the TypeScript code using JSDoc style.
• I added multiple screenshots/screencasts of my UI changes.
• I translated all newly inserted strings into English and German.

Motivation and Context

#7085: Accept a course's code of conduct

Description

Add a guard such that a user can only write messages if they accepted the course's code of conduct.

Steps for Testing

Prerequisites:

• 1 Student/Instructor
• 1 Course

1. Log in to Artemis
2. Navigate to Messages
3. Accept the Code of Conduct
4. Click the Code of Conduct button to look it up
5. Navigate elsewhere
6. Navigate to Messages, the Code of Conduct should remain accepted

Review Progress

Performance Review

• I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
• I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Test Coverage

Client

Class/File	Line Coverage	Confirmation (assert/expect)
user.model.ts	100%	✅
course-update.component.ts	82.3%	✅
course-conversations-code-of-conduct.component.ts	92.85%	✅
course-conversations.component.ts	100%	✅
conversation-selection-sidebar.component.ts	93.25%	✅
file.service.ts	50%	✅
conversation.service.ts	96.38%	✅
metis-conversation.service.ts	83.79%	✅

Server

Class/File	Line Coverage	Confirmation (assert/expect)
ConductAgreement.java	62%	✅
ConductAgreementId.java	43%	✅
ConductAgreementRepository.java	not found (added)	❌
ConductAgreementService.java	100%	✅
ResponsibleUserDTO.java	100%	✅
CourseResource.java	94%	✅
FileResource.java	72%	✅
ConversationResource.java	92%	✅

Screenshots

Screen.Recording.2023-10-12.at.10.46.16.mov

[TimOrtel]

Code Looks good to me

[tobias-lippert]

Reapprove after clarifiying that the change requests are no longer valid.

[lennart-keller]

Code lgtm 👍

[florian-glombik]

Re-approve since no major changes since last review #7154 (comment) and issues are clarified / resolved in follow-ups