Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communication: Accept code of conduct #37

Merged
merged 44 commits into from
Oct 28, 2023

Conversation

@nityanandaz nityanandaz self-assigned this Sep 7, 2023
@nityanandaz nityanandaz mentioned this pull request Oct 14, 2023
25 tasks
# Conflicts:
#	Artemis.xcodeproj/project.pbxproj
#	Artemis.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	core/Navigation/Package.swift
#	feature/CourseRegistration/Package.swift
#	feature/CourseView/Package.swift
#	feature/CourseView/Sources/CourseView/CourseView.swift
#	feature/Dashboard/Package.swift
#	feature/Messages/Package.swift
#	feature/Notifications/Package.swift
- Trailing Whitespace Violation: Lines should not have trailing whitespace (trailing_whitespace)
- 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.
- Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
- File Length Violation: File should contain 400 lines or less: currently contains 428 (file_length)
@nityanandaz nityanandaz marked this pull request as ready for review October 15, 2023 18:38
@nityanandaz nityanandaz requested a review from TimOrtel October 28, 2023 11:32
@nityanandaz nityanandaz merged commit 44df0aa into develop Oct 28, 2023
@nityanandaz nityanandaz deleted the 7085/v2/accept-code-of-conduct branch November 1, 2023 21:11
@nityanandaz nityanandaz mentioned this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant