-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Communication
: Accept code of conduct
#37
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
# Conflicts: # Artemis.xcodeproj/project.pbxproj # Artemis.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # core/Navigation/Package.swift # feature/CourseRegistration/Package.swift # feature/CourseView/Package.swift # feature/CourseView/Sources/CourseView/CourseView.swift # feature/Dashboard/Package.swift # feature/Messages/Package.swift # feature/Notifications/Package.swift
- Trailing Whitespace Violation: Lines should not have trailing whitespace (trailing_whitespace) - 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead. - Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
- File Length Violation: File should contain 400 lines or less: currently contains 428 (file_length)
> Hash values are not guaranteed to be equal across different executions of your program
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Communication
: Accept messaging code of conduct Artemis#7154Communication
: Code of conduct artemis-ios-core-modules#17Development
: Fix HTTP method artemis-ios-core-modules#22