Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ISO format #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use ISO format #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b26d189
Use ISO format
areading314 Nov 16, 2019
eccda97
Remove pad left dependency.
areading314 Nov 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
var prettyBytes = require('prettier-bytes')
var jsonParse = require('fast-json-parse')
var prettyMs = require('pretty-ms')
var padLeft = require('pad-left')
var split = require('split2')
var chalk = require('chalk')
var nl = '\n'
Expand Down Expand Up @@ -79,10 +78,7 @@ function PinoColada () {

function formatDate () {
var date = new Date()
var hours = padLeft(date.getHours().toString(), 2, '0')
var minutes = padLeft(date.getMinutes().toString(), 2, '0')
var seconds = padLeft(date.getSeconds().toString(), 2, '0')
var prettyDate = hours + ':' + minutes + ':' + seconds
var prettyDate = date.toISOString()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find date.toISOString() a bit too convoluted to read. If you want timezone information, I'd probably extract it out and add it to hours/minutes/seconds formatting.

The thing I am not entirely sure about, is whether timezone information is really needed? PinoColada is meant to be used as a development pretty printer, so the timezone that shows up is the one that you as the person doing the development is in. How are you using this that more than one timezone is needed?

Copy link
Author

@areading314 areading314 Jan 31, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of work I do is while SSH'd into various boxes all over the world, so it's nice to see times in a standard timezone, rather than having to remember what the local time would be in each location. Also, we are using this for some production logs (although maybe we shouldn't be?)
which is why dates would be good. Maybe this should be customizeable somehow? For example, there could be a default that does the HH:MM:SS pretty format, and then some env var that can be any date format you like?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh gotcha! If you're using this in production logs, it'd definitely make sense to have it in a more comprehensive date format.

I like the idea of having an env var for this. Would you mind tweaking this PR to include it?

return chalk.gray(prettyDate)
}

Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
"dependencies": {
"chalk": "^2.0.1",
"fast-json-parse": "^1.0.2",
"pad-left": "^2.1.0",
"pad-right": "^0.2.2",
"prettier-bytes": "^1.0.3",
"pretty-ms": "^2.1.0",
Expand Down