-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ISO format #31
base: master
Are you sure you want to change the base?
Use ISO format #31
Conversation
The current "date" format does not include the actual date, which makes the logs a lot less useful. The current implementation also does not include a timezone identifier which can complicate debugging international deployments. Consider this format, which is universally meaningful (and still just as pretty!).
hey @areading314! Using ISO date is a good idea. I think for this PR, I'd still want to have it converted to ISO but extract out hour/minutes/seconds and add the timezone. |
var minutes = padLeft(date.getMinutes().toString(), 2, '0') | ||
var seconds = padLeft(date.getSeconds().toString(), 2, '0') | ||
var prettyDate = hours + ':' + minutes + ':' + seconds | ||
var prettyDate = date.toISOString() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find date.toISOString()
a bit too convoluted to read. If you want timezone information, I'd probably extract it out and add it to hours/minutes/seconds formatting.
The thing I am not entirely sure about, is whether timezone information is really needed? PinoColada is meant to be used as a development pretty printer, so the timezone that shows up is the one that you as the person doing the development is in. How are you using this that more than one timezone is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of work I do is while SSH'd into various boxes all over the world, so it's nice to see times in a standard timezone, rather than having to remember what the local time would be in each location. Also, we are using this for some production logs (although maybe we shouldn't be?)
which is why dates would be good. Maybe this should be customizeable somehow? For example, there could be a default that does the HH:MM:SS pretty format, and then some env var that can be any date format you like?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhh gotcha! If you're using this in production logs, it'd definitely make sense to have it in a more comprehensive date format.
I like the idea of having an env var for this. Would you mind tweaking this PR to include it?
The current "date" format does not include the actual date, which makes the logs a lot less useful. The current implementation also does not include a timezone identifier which can complicate debugging international deployments. Consider this format, which is universally meaningful (and still just as pretty!).