moveit2: fix move_group plugins not found issue #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okvik
changed the title
|
Should this be applied to all ros2 distros not just jazzy? |
Likely. The issue exists from at least Humble and very likely the same fix would work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the long-standing issue discussed in #264
Full credits for this code go to @khaninger with a big thanks to @Takishima for finding and sharing the actual issue.
I initially tried to recreate the approach suggested by @Takishima where various
CMakeFiles.txtget patched but was unsuccessful as this caused other build failures that I had trouble solving, ultimately deciding on a straightforward approach that was already working for me (and apparently others) in practice.This depends on #514 so when that gets merged I can rebase.