Project Scaffolding #2
Conversation
package.json
Outdated
| @@ -0,0 +1,81 @@ | |||
| { | |||
| "name": "shopping", | |||
There was a problem hiding this comment.
@loopback/example-shopping?
|
I'm curious why this example is not added to |
|
Well, this repository will be connected to a database (MongoDB most likely) for testing on Travis which could significantly slow down the builds for @bajtos comment from loopbackio/loopback-next#1476 (comment)
|
|
That's fair. |
| const server = await this.getServer(RestServer); | ||
| const port = await server.get(RestBindings.PORT); | ||
| console.log(`Server is running at http://127.0.0.1:${port}`); | ||
| console.log(`Try http://127.0.0.1:${port}/ping`); |
There was a problem hiding this comment.
IIRC, this template has been updated recently to use this.restServer.url, see loopbackio/loopback-next#1572. Could you please update the implementation of start method accordingly? Feel free to do so in a follow-up pull request, I think it will be easier to review.
Signed-off-by: virkt25 <[email protected]>
virkt25
force-pushed
the
init
branch
2 times, most recently
from
86fa90e to
e09e2b7
Compare
Signed-off-by: virkt25 <[email protected]>
Signed-off-by: virkt25 <[email protected]>
Signed-off-by: virkt25 <[email protected]>
Signed-off-by: virkt25 <[email protected]>
Signed-off-by: virkt25 <[email protected]>
This creates the scaffolding for this example. The app was generated using
lb4 shopping. Subsequent changes to the application are documented based on commits (should also make review easier).COMMITS