Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update files to match latest CLI template output #3

Merged
merged 1 commit into from
Aug 15, 2018
Merged

chore: update files to match latest CLI template output #3

merged 1 commit into from
Aug 15, 2018

Conversation

virkt25
Copy link
Contributor

@virkt25 virkt25 commented Aug 14, 2018

Signed-off-by: virkt25 [email protected]

Based on #2 (comment)

  • Updates application.ts and index.ts to match latest CLI project templates.

@virkt25 virkt25 requested a review from bajtos August 14, 2018 00:05
@virkt25 virkt25 self-assigned this Aug 14, 2018
@virkt25 virkt25 requested review from a team and raymondfeng August 14, 2018 00:05
bajtos
bajtos approved these changes Aug 14, 2018
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, please check why the CI builds are failing.

@virkt25
Copy link
Contributor Author

virkt25 commented Aug 15, 2018

Travis commit-lint task had timed out. As for commit-linter, it's not the same rules as the one on Travis (which is what we follow). Commit Linter and PR Linter need to be disabled for this repo.

Ignoring Commit Linter.

@virkt25 virkt25 merged commit d92fb37 into master Aug 15, 2018
@virkt25 virkt25 deleted the template branch August 15, 2018 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos approved these changes

@raymondfeng raymondfeng Awaiting requested review from raymondfeng

Assignees

@virkt25 virkt25

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@virkt25 @bajtos