-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Short-term solution for hiddenProperties in model #3265
Conversation
Signed-off-by: Renovate Bot <[email protected]>
Thank you @frbuceta for the pull request. Please rebase your patch on top of the latest master (see https://loopback.io/doc/en/lb4/submitting_a_pr.html) and add a test to verify your changes & prevent regressions in the future. |
The rest of the steps are not necessary, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the new changes, the pull request looks almost good now! Please see my comments below.
Also, please rebase your pull request on top of the latest master using git rebase
(we are not using git merge
for that) and squash all commits into a single one.
Can I close this Pull Request and open another? I deleted the fork and now it does not let me change anything @bajtos |
Implement short-term solution to hide properties in a model
close: #1914
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated👉 Check out how to submit a PR 👈