Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Short-term solution for hiddenProperties in model #3265

Closed
wants to merge 7 commits into from
Closed

Add Short-term solution for hiddenProperties in model #3265

wants to merge 7 commits into from

Conversation

frbuceta
Copy link
Contributor

@frbuceta frbuceta commented Jun 27, 2019

Implement short-term solution to hide properties in a model

close: #1914

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@bajtos
Copy link
Member

bajtos commented Jun 28, 2019

Thank you @frbuceta for the pull request. Please rebase your patch on top of the latest master (see https://loopback.io/doc/en/lb4/submitting_a_pr.html) and add a test to verify your changes & prevent regressions in the future.

@bajtos bajtos self-assigned this Jun 28, 2019
@bajtos bajtos added feature Repository Issues related to @loopback/repository package labels Jun 28, 2019
@bajtos bajtos mentioned this pull request Jun 28, 2019
@frbuceta
Copy link
Contributor Author

The rest of the steps are not necessary, right?

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the new changes, the pull request looks almost good now! Please see my comments below.

Also, please rebase your pull request on top of the latest master using git rebase (we are not using git merge for that) and squash all commits into a single one.

@frbuceta
Copy link
Contributor Author

frbuceta commented Jul 2, 2019

Can I close this Pull Request and open another? I deleted the fork and now it does not let me change anything @bajtos frbuceta wants to merge 7 commits into strongloop:master from unknown repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Repository Issues related to @loopback/repository package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hidden properties
5 participants