Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Short-term solution for hiddenProperties in model #3304

Merged
merged 1 commit into from
Jul 19, 2019
Merged

Add Short-term solution for hiddenProperties in model #3304

merged 1 commit into from
Jul 19, 2019

Conversation

frbuceta
Copy link
Contributor

@frbuceta frbuceta commented Jul 3, 2019

Implements #1914
See also #3265

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@bajtos bajtos added community-contribution feature feature parity Repository Issues related to @loopback/repository package labels Jul 4, 2019
@bajtos bajtos self-assigned this Jul 4, 2019
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there 😄

@raymondfeng PTAL, I'd like to hear your opinion on this approach.

docs/site/Model.md Outdated Show resolved Hide resolved
@frbuceta
Copy link
Contributor Author

frbuceta commented Jul 4, 2019

AppVenyor fails, but I do not know why ...

WARN tarball tarball data for @lerna/[email protected] (sha512-yKHuifADINobvDOLljBGkVGpVwy6J3mg5p9lQXBdOLXBoIKC8o/UKBR9JvZMFvT/Iy6zn6FPy1v5lz9iU1Ib0Q==) seems to be corrupted. Trying one more time.
WARN tarball tarball data for [email protected] (sha512-7KxJovlYhTX5RaRbUdkAXN1KUZ8PwWlTzQdHV6xNqvuFOs7+WBo10TQUqT19Q/Jz2hk5v9TQDIhyLhhJY4p5AA==) seems to be corrupted. Trying one more time.
npm ERR! path C:\projects\loopback-next\node_modules\@lerna\link\command.js
npm ERR! code EPERM
npm ERR! errno -4048
npm ERR! syscall unlink
npm ERR! Error: EPERM: operation not permitted, unlink 'C:\projects\loopback-next\node_modules\@lerna\link\command.js'
npm ERR!  { Error: EPERM: operation not permitted, unlink 'C:\projects\loopback-next\node_modules\@lerna\link\command.js'
npm ERR!   cause: 
npm ERR!    { Error: EPERM: operation not permitted, unlink 'C:\projects\loopback-next\node_modules\@lerna\link\command.js'
npm ERR!      type: 'OperationalError',
npm ERR!      '$error': '$error',
npm ERR!      cause: 
npm ERR!       { errno: -4048,
npm ERR!         code: 'EPERM',
npm ERR!         syscall: 'unlink',
npm ERR!         path: 'C:\\projects\\loopback-next\\node_modules\\@lerna\\link\\command.js' },
npm ERR!      isOperational: true,
npm ERR!      errno: -4048,
npm ERR!      code: 'EPERM',
npm ERR!      syscall: 'unlink',
npm ERR!      path: 'C:\\projects\\loopback-next\\node_modules\\@lerna\\link\\command.js' },
npm ERR!   isOperational: true,
npm ERR!   stack: 'Error: EPERM: operation not permitted, unlink \'C:\\projects\\loopback-next\\node_modules\\@lerna\\link\\command.js\'',
npm ERR!   type: 'OperationalError',
npm ERR!   '$error': '$error',
npm ERR!   errno: -4048,
npm ERR!   code: 'EPERM',
npm ERR!   syscall: 'unlink',
npm ERR!   path: 'C:\\projects\\loopback-next\\node_modules\\@lerna\\link\\command.js' }
npm ERR! 
npm ERR! The operation was rejected by your operating system.
npm ERR! It's possible that the file was already in use (by a text editor or antivirus),
npm ERR! or that you lack permissions to access it.
npm ERR! 
npm ERR! If you believe this might be a permissions issue, please double-check the
npm ERR! permissions of the file and its containing directories, or try running
npm ERR! the command again as root/Administrator (though this is not recommended).
npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\appveyor\AppData\Roaming\npm-cache\_logs\2019-07-04T17_50_56_668Z-debug.log

docs/site/Model.md Outdated Show resolved Hide resolved
docs/site/Model.md Outdated Show resolved Hide resolved
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@raymondfeng I'll leave the final approval and landing of this pull request up to you.

docs/site/Model.md Outdated Show resolved Hide resolved
@dhmlau dhmlau merged commit e669913 into loopbackio:master Jul 19, 2019
@dhmlau
Copy link
Member

dhmlau commented Jul 19, 2019

@frbuceta, thanks for your contribution. Your PR has landed! 🎉

@frbuceta frbuceta deleted the hidden-properties branch July 19, 2019 17:12
@dhmlau dhmlau mentioned this pull request Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature parity feature Repository Issues related to @loopback/repository package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants