Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify example in first-scene.md #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clarify example in first-scene.md #58

wants to merge 1 commit into from

Conversation

winstonrc
Copy link
Contributor

I think this makes it a bit clearer that the word mesh is a placeholder for the object. The way it currently reads, a novice might think following the example that they should literally use scene.remove(mesh) instead of scene.remove(cube).

I think this makes it a bit clearer that the word _mesh_ is a placeholder for the object. The way it currently reads, a novice might think following the example that they should literally use `scene.remove(mesh)` instead of `scene.remove(cube)`.
@looeee
Copy link
Owner

looeee commented Aug 15, 2022

Let me think about this one. Maybe I need to reword that section a bit.

I need to make some small updates across the site and bump the three.js version. I will try to find some time to do that later this week or early next week. I'll review this section and all your changes will go live then too.

@winstonrc winstonrc closed this by deleting the head repository Sep 2, 2022
@looeee
Copy link
Owner

looeee commented Sep 3, 2022

@winstoncooke apologies that it's taking so long to get your updates on the live site.
It so happens to have clashed with the new Chinese translation so it's taking a bit longer to get the updates out this time.

@winstonrc
Copy link
Contributor Author

Oops I didn't mean to delete this!

And no worries at all. Just happy to help.

@winstonrc winstonrc reopened this Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants