Obsolete ssl_certificate_verification option #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
|
@suyograo +1 on your labeling. I believe that going straight to |
|
@jordansissel you're correct. If you tried to use this and connect to a host with a bad cert you'd get an error. |
|
Andrew Cholakian merged this into the following branches!
|
This was referenced Aug 5, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completely removes this option which didn't work anyway.
Currently trying to disable ssl verification will still give you errors and warnings.
This is possible to fix but there is added complexity here since manticore does not support the right hooks into Apache HC to do this properly (cheald/manticore#53).
For the time being it is best to just obsolete this option so as not to confuse people.